[vlc-devel] [PATCH] Added hotkey for video transformation. Pressing Ctrl+Alt+r the user can navigate through the available transformation modes.

[Stefanos Orovas]

>
> I told you already. It clobbers the configuration and will not work if
> there is a command line parameter.


In my installation, when i pass a parameter via command line i am not able
to change the orientation from the settings panel.
So, should we make it possible to change the orientation from settings
screen? Because i used the same code in the hotkey and it's wrong.



2014-02-11 10:23 GMT+02:00 Rémi Denis-Courmont <remi at remlab.net>:

> On Tue, 11 Feb 2014 01:44:38 +0200, Stefanos Orovas
> <stef.orovas at gmail.com>
> wrote:
> >>
> > I tried but didn't get a result. Can you please provide me more info?
>
> I cannot explain it any better.
>
> >> +             config_PutPsz( p_intf, "transform-type", transform_type
> );
> >> > +             config_PutPsz( p_intf, "video-filter", psz_string );
> >>
> >> As pointed out previously, this would clobber the user configuration.
> >> Please stick to var_*().
> >>
> >
> > I see in file modules/gui/qt4/components/extended_panels.cpp that the
> > "transform-type" changes by using config_PutPsz() (when user selects it
> > from the dropdown menu in settings) but you mentioned that i shouldn't
> use
> > this function. Why is it wrong to use it on the hotkey?
>
> I told you already. It clobbers the configuration and will not work if
> there is a command line parameter.
>
> --
> Rémi Denis-Courmont
> Sent from my collocated server
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140211/17d2ada1/attachment.html>