[vlc-devel] [PATCH] Pause Spotify when video playback starts

David Fuhrmann david.fuhrmann at gmail.com
Fri Feb 14 13:57:36 CET 2014


Am 14.02.2014 um 13:35 schrieb Allan Odgaard <lists+vlc at simplit.com>:

> I could see support for more players down the road, so it might make sense to introduce a more generic word, like “external music player”.

Thanks for your patch. Maybe it might make sense to rename macosx-control-itunes to a more generic variant, like macosx-control-mediaplayers?
Additionally, I am not so much fan of always mentioning "iTunes / Spotify". We should mention the supported players somewhere, but maybe only once (in the tooltip?).

Else, patch looks fine.

> I btw notice that the label for the setting in the simple and advanced preferences window is different. In the simple we have “Control iTunes during playback” where the advanced use “Pause iTunes during VLC playback”. Don’t know if this is intentional.

Thanks for pointing it out. Of course it is better to only have one variant.

With best regards,

More information about the vlc-devel mailing list