[vlc-devel] [PATCH] securetransport: Add TLS server module

[Felix Paul Kühne]

Hey David,

Patch looks good to me.

Trivial remarks inline.

On 10.01.2014, at 15:34, david.fuhrmann at gmail.com wrote:

> +#if !TARGET_OS_IPHONE
> +    add_submodule()
> +        set_description(N_("TLS server support for OS X"))
> +        set_capability("tls server", 2)
> +        set_callbacks(OpenServer, CloseServer)
> +        set_category(CAT_ADVANCED)
> +        set_subcategory(SUBCAT_ADVANCED_NETWORK)
> +#endif /* !TARGET_OS_IPHONE */

Is there a technical limitation blocking deployment on iOS or is this because we don't have stream output available on iOS so far?
Could you add a comment explaining the rationale?

> 
> +    if(ret != noErr) {
> +        goto error;
> +    }
> +
> +    vlc_tls_sys_t *sys = session->sys;
> +    sys->b_server_mode = true;
> +
> +    ret = SSLSetCertificate (sys->p_context, crd->sys->server_cert_chain);
> +    if (ret != noErr) {
> +        msg_Err (session, "cannot set server certificate");
> +        goto error;
> +    }

Inconsistent coding styles at multiple places throughout the patch.

> +#endif /* !TARGET_OS_IPHONE */
> \ No newline at end of file

^^^ :-)

Cheers!

Felix