[vlc-devel] [PATCH 2/2] android: use common function LoadNativeWindowAPI instead of duplicating code in vout modules.
martin at martin.st
Wed Jan 15 09:31:47 CET 2014
On Tue, 14 Jan 2014, Felix Abecassis wrote:
> modules/video_output/Modules.am | 4 +--
> modules/video_output/android/nativewindow.c | 41 +++------------------
> modules/video_output/android/surface.c | 55 ++++++-----------------------
> 3 files changed, 18 insertions(+), 82 deletions(-)
These patches look ok to me.
However, I'm not sure how much point these is in loading these functions
dynamically any longer. Since we already link to EGL (which only is
available since 2.3 - native GL functions are available since much earlier
but EGL was exposed only at that point) the binary can't be loaded on
pre-2.3 devices. Therefore there's no point in doing all this extra work
for the ANativeWindow functions either, which could be linked directly and
the old hacky stuff could be removed from surface.c (and the OpenSL ES
output could be simplified as well).
So we should choose a stance in this - are we going to try to maintain
compatibility with pre-2.3 (I don't have any such device running armv7 to
test on, only armv6 ones), then we should dlopen/dlsym EGL as well, or
just skip the extra compatibility dance for something that's of little
actual benefit (and is really hard to test) and simplify the code at the
More information about the vlc-devel