[vlc-devel] [PATCH 2/2] android: use common function LoadNativeWindowAPI instead of duplicating code in vout modules.

[Felix Abecassis]

2014/1/15 Martin Storsjö <martin at martin.st>:
> On Tue, 14 Jan 2014, Felix Abecassis wrote:
>
>> ---
>> modules/video_output/Modules.am             |  4 +--
>> modules/video_output/android/nativewindow.c | 41 +++------------------
>> modules/video_output/android/surface.c      | 55
>> ++++++-----------------------
>> 3 files changed, 18 insertions(+), 82 deletions(-)
>
>
> These patches look ok to me.
>
> However, I'm not sure how much point these is in loading these functions
> dynamically any longer. Since we already link to EGL (which only is
> available since 2.3 - native GL functions are available since much earlier
> but EGL was exposed only at that point) the binary can't be loaded on
> pre-2.3 devices. Therefore there's no point in doing all this extra work for
> the ANativeWindow functions either, which could be linked directly and the
> old hacky stuff could be removed from surface.c (and the OpenSL ES output
> could be simplified as well).
But we only link for EGL for the OpenGL vout I think, in this case we
should simply disable this vout for 2.2 devices (if it's not the case
already) and the rest of the code should run fine.

Ping other devs: are there UI requirements that would make it
worthwhile to drop support of pre-2.3 versions?

-- 
Félix Abecassis
http://felix.abecassis.me