[vlc-devel] [PATCH 3/3] lib/media_player: inherit deinterlace and vbi variables to fix correct variables values on first use

[Rémi Denis-Courmont]

On Wed, 22 Jan 2014 14:16:46 +0100, Felix Paul Kühne
<fkuehne at videolan.org>
wrote:
> ---
>  lib/media_player.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/media_player.c b/lib/media_player.c
> index c23dd42..df23b7c 100644
> --- a/lib/media_player.c
> +++ b/lib/media_player.c
> @@ -411,10 +411,10 @@ libvlc_media_player_new( libvlc_instance_t
*instance
> )
>      var_SetFloat (mp, "scale", 1.);
>      var_Create (mp, "aspect-ratio", VLC_VAR_STRING);
>      var_Create (mp, "crop", VLC_VAR_STRING);
> -    var_Create (mp, "deinterlace", VLC_VAR_INTEGER);
> +    var_Create (mp, "deinterlace", VLC_VAR_INTEGER |
VLC_VAR_DOINHERIT);
>      var_Create (mp, "deinterlace-mode", VLC_VAR_STRING);
>  
> -    var_Create (mp, "vbi-page", VLC_VAR_INTEGER);
> +    var_Create (mp, "vbi-page", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT);

There are no defined code paths that would lead to these variables having
a non-zero values. This is a pointless loss of CPU time and wrong.

>  
>      var_Create (mp, "marq-marquee", VLC_VAR_STRING);
>      var_Create (mp, "marq-color", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT);

-- 
Rémi Denis-Courmont
Sent from my collocated server