[vlc-devel] [PATCH 3/3] lib/media_player: inherit deinterlace and vbi variables to fix correct variables values on first use

[Rémi Denis-Courmont]

On Wed, 22 Jan 2014 14:42:53 +0100, Rémi Denis-Courmont <remi at remlab.net>
wrote:
>> -    var_Create (mp, "deinterlace", VLC_VAR_INTEGER);
>> +    var_Create (mp, "deinterlace", VLC_VAR_INTEGER |
> VLC_VAR_DOINHERIT);
>>      var_Create (mp, "deinterlace-mode", VLC_VAR_STRING);
>>  
>> -    var_Create (mp, "vbi-page", VLC_VAR_INTEGER);
>> +    var_Create (mp, "vbi-page", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT);
> 
> There are no defined code paths that would lead to these variables
having
> a non-zero values. This is a pointless loss of CPU time and wrong.

For deinterlace, that is. For vbi-page, there should be a var_Set(100) -
or a new var_Create() flag to explicitly take the default value rather than
zero.

-- 
Rémi Denis-Courmont
Sent from my collocated server