[vlc-devel] [PATCH] codec: jpeg encoder implemented

[Jean-Baptiste Kempf]

On 24 Jan, Maxim Bublis wrote :
> No quality set ?
> >
> 
> I guess, configuration option should be added for jpeg screenshots, but
> currently no one exists.
> I've hardcoded 100% quality for now, but I'll look how to add configuration
> options.

What's the size for 95% ?

> > And I wonder whether we should, or not disable-sout for images (because
> > it might be nice for screenshots).
> 
> I've looked at avcodec code, as you know it is currently used for jpeg
> screenshots, it uses the same #ifdef for its encoder.
> Maybe it should be removed in case of jpeg encoder.

Well, avcodec is big. This might not be.

> > Why removing all this code?
> 
> I've found this code useless, as on any error libjpeg always setjmp's, and
> that code never executes.

Then, it needs a different commit.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device