[vlc-devel] [PATCH] Direct3D: implement HLSL pixel shading in the rendering pipeline

[Jean-Baptiste Kempf]

On 28 Jan, Rafaël Carré wrote :
> >      // core objects
> >      HINSTANCE               hd3d9_dll;       /* handle of the opened d3d9 dll */
> > +    HINSTANCE               hd3d9x_dll;      /* handle of the opened d3d9x dll */
> 
> Why not linking directly to the DLL ?

Because in theory, some Windows version don't have those.

I think it is better this way.

> BTW I notice that these 2 members (and those below) are not common to all
> msw vout modules, they should be moved to direct3d.c

+1

> > +    sys->hd3d9x_dll = Direct3DLoadShaderLibrary();
> > +    if (!sys->hd3d9x_dll)
> > +        msg_Warn(vd, "cannot load Direct3D Shader Library; HLSL pixel shading will be disabled.");
> 
> Is d3dx9_x.dll only a 'shader library' ?

No, but mostly.

I think the X meant Extended.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device