[vlc-devel] [PATCH] Direct3D: implement HLSL pixel shading in the rendering pipeline

[Rafaël Carré]

On 01/28/14 10:38, Jean-Baptiste Kempf wrote:
> On 28 Jan, Rafaël Carré wrote :
>>>      // core objects
>>>      HINSTANCE               hd3d9_dll;       /* handle of the opened d3d9 dll */
>>> +    HINSTANCE               hd3d9x_dll;      /* handle of the opened d3d9x dll */
>>
>> Why not linking directly to the DLL ?
> 
> Because in theory, some Windows version don't have those.

Can it have d3d9 but not d3d9x ?

In any case d3d9 should also be linked directly.

If the dll is absent the module would fail to load and we would waste
less CPU.

> I think it is better this way.

>>> +    sys->hd3d9x_dll = Direct3DLoadShaderLibrary();
>>> +    if (!sys->hd3d9x_dll)
>>> +        msg_Warn(vd, "cannot load Direct3D Shader Library; HLSL pixel shading will be disabled.");
>>
>> Is d3dx9_x.dll only a 'shader library' ?
> 
> No, but mostly.

Ok

> I think the X meant Extended.
> 
> With my kindest regards,
>