[vlc-devel] [PATCH 3/3] lib/media_player: inherit deinterlace and vbi variables to fix correct variables values on first use

[Felix Paul Kühne]

Hello,

On 28.01.2014, at 10:06, Rafaël Carré <funman at videolan.org> wrote:

> Hello,
> 
> On 01/22/14 14:16, Felix Paul Kühne wrote:
>> ---
>> lib/media_player.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/lib/media_player.c b/lib/media_player.c
>> index c23dd42..df23b7c 100644
>> --- a/lib/media_player.c
>> +++ b/lib/media_player.c
>> @@ -411,10 +411,10 @@ libvlc_media_player_new( libvlc_instance_t *instance )
>>     var_SetFloat (mp, "scale", 1.);
>>     var_Create (mp, "aspect-ratio", VLC_VAR_STRING);
>>     var_Create (mp, "crop", VLC_VAR_STRING);
>> -    var_Create (mp, "deinterlace", VLC_VAR_INTEGER);
>> +    var_Create (mp, "deinterlace", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT);
> 
> You are supposed to use libvlc_video_set_deinterlace and
> libvlc_video_set_teletext

Well, this is what I do within VLCKit.

>>     var_Create (mp, "deinterlace-mode", VLC_VAR_STRING);
>> 
>> -    var_Create (mp, "vbi-page", VLC_VAR_INTEGER);
>> +    var_Create (mp, "vbi-page", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT);
>> 
>>     var_Create (mp, "marq-marquee", VLC_VAR_STRING);
>>     var_Create (mp, "marq-color", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT);
> 
> In fact INHERIT should be removed for most if not all options here

Can you elaborate this stance?

Cheers,

Felix