[vlc-devel] [PATCH 3/3] lib/media_player: inherit deinterlace and vbi variables to fix correct variables values on first use

[Rémi Denis-Courmont]

On Tue, 28 Jan 2014 10:35:16 +0100, Jean-Baptiste Kempf <jb at videolan.org>
wrote:
> On 28 Jan, Rafaël Carré wrote :
>> Hello,
>> 
>> On 01/22/14 14:16, Felix Paul Kühne wrote:
>> > ---
>> >  lib/media_player.c | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> > 
>> > diff --git a/lib/media_player.c b/lib/media_player.c
>> > index c23dd42..df23b7c 100644
>> > --- a/lib/media_player.c
>> > +++ b/lib/media_player.c
>> > @@ -411,10 +411,10 @@ libvlc_media_player_new( libvlc_instance_t
>> > *instance )
>> >      var_SetFloat (mp, "scale", 1.);
>> >      var_Create (mp, "aspect-ratio", VLC_VAR_STRING);
>> >      var_Create (mp, "crop", VLC_VAR_STRING);
>> > -    var_Create (mp, "deinterlace", VLC_VAR_INTEGER);
>> > +    var_Create (mp, "deinterlace", VLC_VAR_INTEGER |
>> > VLC_VAR_DOINHERIT);
>> 
>> You are supposed to use libvlc_video_set_deinterlace and
>> libvlc_video_set_teletext
> 
> Sure, but does it hurt?

It hurts in the long term because developers will cargo cult the wrong and
unsupported solution instead of reading the documentation, yes.

-- 
Rémi Denis-Courmont
Sent from my collocated server