[vlc-devel] smem: Use size_t for buffer sizes & fix warning

Hugo Beauzée-Luyssen hugo at beauzee.fr
Tue Jan 28 23:42:00 CET 2014

On Wed, Jan 29, 2014 at 12:35 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> This breaks the callback on a few odd architectures. But since those callbacks
> are not part of any supported interface, I do not care. The use of String
> instead of Address hurts my retinas harder than unsigned for size_t, though.
> So patch 1 seems fine.
> Le mercredi 29 janvier 2014, 00:17:01 Hugo Beauzée-Luyssen a écrit :
>> This is a set of minor changes for smem.
>> I realize the warning is a false positive, but, well, still good to fix
>> imho.
> Debatable. What if another compiler version now complains that the value is
> assigned but never used?
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

Agreed for point 1 (including the part about strings). I guess I can
also update the wiki.
Point 2: it changes so little that I really don't care, up to the
reviewers. Does not warn on gcc4.8, didn't try clang.


Hugo Beauzée-Luyssen
mail: hugo at beauzee.fr
skype: beauze.h

More information about the vlc-devel mailing list