[vlc-devel] [PATCH] Added coreanimation opengl layer vout module

[Jean-Baptiste Kempf]

On 29 Jan, david.fuhrmann at gmail.com wrote :
> This module is used for video output with the windowed npapi plugin.

Can it work outside?

>  configure.ac                         |   8 +
>  modules/video_output/Modules.am      |   7 +
>  modules/video_output/caopengllayer.m | 468 +++++++++++++++++++++++++++++++++++
>  3 files changed, 483 insertions(+)
>  create mode 100644 modules/video_output/caopengllayer.m

Missing NEWS, MODULE_LIST and maybe po/POTFILES.in

> +#import <dlfcn.h>

Why do you need this?

> +    msg_Dbg(vd, "init ca opengl layer plugin");

Do we really need that?

> +bailout:
> +    return VLC_EGENERIC;
> +}

Leaks. Maybe you should call Close.

Rest seems good.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device