[vlc-devel] [PATCH] Added coreanimation opengl layer vout module
david.fuhrmann at gmail.com
Wed Jan 29 14:52:51 CET 2014
Am 29.01.2014 um 14:41 schrieb Jean-Baptiste Kempf <jb at videolan.org>:
> On 29 Jan, david.fuhrmann at gmail.com wrote :
>> This module is used for video output with the windowed npapi plugin.
> Can it work outside?
Outside the windowed mode? I assume not, but I am not sure. Outside npapi? Should work, but I did not tested.
>> configure.ac | 8 +
>> modules/video_output/Modules.am | 7 +
>> modules/video_output/caopengllayer.m | 468 +++++++++++++++++++++++++++++++++++
>> 3 files changed, 483 insertions(+)
>> create mode 100644 modules/video_output/caopengllayer.m
> Missing NEWS, MODULE_LIST and maybe po/POTFILES.in
>> +#import <dlfcn.h>
> Why do you need this?
Its needed for dlsym. I will add a comment after the include.
>> + msg_Dbg(vd, "init ca opengl layer plugin");
> Do we really need that?
No, removed this.
>> + return VLC_EGENERIC;
> Leaks. Maybe you should call Close.
I will send an updated patch if its desired.
With best regards,
More information about the vlc-devel