[vlc-devel] [PATCH] Added coreanimation opengl layer vout module

[Felix Paul Kühne]

Hey Rémi,

On 29.01.2014, at 17:12, Rémi Denis-Courmont <remi at remlab.net> wrote:

> Le mercredi 29 janvier 2014, 16:28:17 Felix Paul Kühne a écrit :
>> Hey Rémi,
>> 
>> On 29.01.2014, at 16:15, Rémi Denis-Courmont <remi at remlab.net> wrote:
>>> On Wed, 29 Jan 2014 15:07:56 +0100, david.fuhrmann at gmail.com wrote:
>>>> From: David Fuhrmann <david.fuhrmann at googlemail.com>
>>>> 
>>>> This module is used for video output with the windowed npapi plugin.
>>>> ---
>>>> NEWS                                 |   1 +
>>>> configure.ac                         |   8 +
>>> 
>>> Again, when do you guys stop adding -pretty pointless- configure switches
>>> for every single plugin you make? What's the point?
>> 
>> The point in this case is that this module will only be used for the NPAPI
>> plugin and possibly in the future with the VLCKit framework.
> 
> So? How many people compile VLC on MacOS and will care about the overhead? 
> Probably zero.

Well, we are afraid it would be listed as an available video output module in the preferences and clueless users will select it because it sounds interesting and blame us that VLC won't work anymore. The ~20kB of wasted disk space are clearly negligible.

> There are plenty of mostly useless plugins and we do not have 
> switches for them unless they add an external dependency.

Yep, this is the reason why the Android and iOS targets include a black list to delete useless modules after compilation, but this isn't a very clean way of doing things IMO.

> 
>> It will not be
>> used for the mainline VLC distribution and won't be used for iOS either.
>> So, IMO, it's quite reasonable to have a switch to enable or disable it
>> depending on what you'd like to do with libvlc.
> 
> Sure, if you remove all the *other* MacOS switches for which this 
> consideration does *not* apply, then yes.

I'll happily go through the list by the end of the week and check if we can remove useless stuff like "--enable-macosx-audio", etc.

Cheers,

Felix