[vlc-devel] [PATCH] src: input/stream: fix buffer underflow by avoiding inconsistent state in error case

Rémi Denis-Courmont remi at remlab.net
Thu Jul 3 22:41:53 CEST 2014


I spent time to review your code and explain what's wrong, and again, and 
again. And instead of fixing your patch, you misrepresent my review comments, 
offend me and attempt to publicly disavow me, the sole (in this case) reviewer. 
Defending a patch against a confused review is one thing; trolling the 
reviewer is another. I am ostensibly not in a position to complain about 
other's attitude, but I must say I do not find this adequate.

Do I need to mention that your deliberately ignored my (and the only) review 
of the input item changes, and pushed the badly designed and badly implemented 
playback resumption feature(*)? To add pain to injury, you pushed it in 
contempt of the ongoing code freeze. With all that in mind, examplary is not a 
word that comes to my mind to describe your recent contributions. I gather 
that other people have already brought this up in the past, but maybe you 
should rethink your ways of working and your attitude.

N.B.: I am the only active committer with meaningful changes to 
src/input/stream* since Laurent left. Your patch is rejected.

(*) Unfortunately, JB naively translated that horrible implementation -of an 
otherwise useful and much requested feature- into the Qt UI shortly 
afterwards, so now everybody suffers. Bugs are already filed, and not only by 

Rémi Denis-Courmont

More information about the vlc-devel mailing list