[vlc-devel] [PATCH] src: input/stream: fix buffer underflow by avoiding inconsistent state in error case
david.fuhrmann at gmail.com
Thu Jul 3 23:52:22 CEST 2014
First, please be assured that I do not intended to offend you. Its just that your explanations are sometimes really to generic for me and most others.
Generally, _please_ complain to the specific patches or issues you are having a problem with. Doing that in a totally unrelated thread, and weeks or months afterwards ist not really helpful.
But as you are mention it, I will write some words about it:
Am 03.07.2014 um 22:41 schrieb Rémi Denis-Courmont <remi at remlab.net>:
> Do I need to mention that your deliberately ignored my (and the only) review
> of the input item changes,
First, I answered your concerns in this regard. A lack of answer means that you / the person has accepted the answer and that they are no further concerns. Please state if you are still disagreeing after explanations. Please do not blame me now if you was not doing so in this situation.
Second, the patch in concern was reviewed and approved by j-b. He even complained when I reverted it.
In this situation, and because of lack of further input, I thought it was fine to push the patch. Thus, your current accusation is completely unfounded from my point of view.
> and pushed the badly designed and badly implemented
> playback resumption feature(*)? To add pain to injury, you pushed it in
> contempt of the ongoing code freeze.
Making false accusations it _not_ acceptable for me, so please check before you complain.
The _sole_ responsibility of the resume playback feature is with Felix. He pushed the initial version, and after I found and fixed some rather trivial issues in the data format, I heavily complained to Felix because it was not really working at all. Also, the second iteration on the feature was only done by Felix. So this point is completely unfounded as well.
I will ignore all the other accusations against me or my attitude in your mail. If you have any problems, please write or tell me directly.
With best regards,
More information about the vlc-devel