[vlc-devel] src/input: add a new input option flag to replace values of existing options (was: fix buffer underflow by avoiding inconsistent state in error case)

Rémi Denis-Courmont remi at remlab.net
Fri Jul 4 09:47:22 CEST 2014


Le 2014-07-04 00:52, David Fuhrmann a écrit :
> Generally, _please_ complain to the specific patches or issues you
> are having a problem with. Doing that in a totally unrelated thread,
> and weeks or months afterwards ist not really helpful.

I cannot report issues before I find them (that would be two days ago 
on Trac). Regardless of who violated it, the whole point about code 
freezes is to not make regression-prone changes when there is not enough 
time to find and address bugs timely.

>> Do I need to mention that your deliberately ignored my (and the 
>> only) review
>> of the input item changes,
> First, I answered your concerns in this regard. A lack of answer
> means that you / the person has accepted the answer and that they are
> no further concerns.

So I "accepted" the answer, since it said you agreed with the review:

At that point, the reasonable expectation is for an amended patch on 
the mailing list. Instead you went ahead without actually taking the 
review comments into account. That is ignoring my review comments. 

> Please state if you are still disagreeing after
> explanations.


> Please do not blame me now if you was not doing so in
> this situation.


> Second, the patch in concern was reviewed and approved by j-b. He
> even complained when I reverted it.

It is you, not j-b, that ignored my review comments. Almost every 
developer has ignored a review at some point and indeed the reviewer can 
be wrong sometimtes. But you should expect to be held "accountable" 

> In this situation, and because of lack of further input, I thought it
> was fine to push the patch. Thus, your current accusation is
> completely unfounded from my point of view.

As far as the input item options are concerned, I seems my "accusation" 
-if you want to call it that- is totally founded and I stand by it.

(I might have been confused regarding the resume feature otherwise.)

Rémi Denis-Courmont

More information about the vlc-devel mailing list