[vlc-devel] [PATCH] contrib/gpg-error: disable tests

[Jean-Baptiste Kempf]

On 07 Jul, Felix Paul Kühne wrote :
> 
> On 04.07.2014, at 18:30, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> 
> > Le 03/07/2014 15:48, Felix Paul Kühne a écrit :
> >> +diff -ru libgpg-error/Makefile.in libgpg-error-fixed/Makefile.in
> >> +--- libgpg-error/Makefile.in	2014-04-15 14:25:49.000000000 +0200
> >> ++++ libgpg-error-fixed/Makefile.in	2014-07-04 00:46:04.000000000 +0200
> > 
> > Please patch Makefile.am and use RECONF
> 
> I agree that this would be the more typical way to solve this kind of issue. However, $(RECONF) depends on autopoint, so executing this macro would add the gettext dependency for a single, quite minor library to achieve the same result (gettext is not needed at all this point to compile all contrib libraries for the iOS port), so I'd prefer my approach as long as we don't need $(RECONF) for anything other purpose regarding libgpg-error.

Well, sorry, but RECONF is necessary for most contribs. Not to mention
that you need gettext to have a proper libVLC.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device