[vlc-devel] [PATCH 1/9] VLCKit: migrate VLCMedia to ARC

[Felix Paul Kühne]

Hey Florent,

On 11.07.2014, at 01:35, Florent Pillet <fpillet at gmail.com> wrote:

> ---
> Headers/Public/VLCMedia.h |  14 +--
> Sources/VLCMedia.m        | 283 ++++++++++++++++++++--------------------------
> 2 files changed, 131 insertions(+), 166 deletions(-)
> 
> diff --git a/Headers/Public/VLCMedia.h b/Headers/Public/VLCMedia.h
> index 6fc924a..f5d6aa5 100644
> --- a/Headers/Public/VLCMedia.h
> +++ b/Headers/Public/VLCMedia.h
> @@ -186,14 +186,14 @@ typedef NSInteger VLCMediaState;
> /**
>  * Receiver's delegate.
>  */
> - at property (weak) id<VLCMediaDelegate> delegate;
> + at property (nonatomic, weak) id<VLCMediaDelegate> delegate;
> 
> /**
>  * A VLCTime object describing the length of the media resource, only if it is
>  * available.  Use lengthWaitUntilDate: to wait for a specified length of time.
>  * \see lengthWaitUntilDate
>  */
> - at property (readonly) VLCTime * length;
> + at property (nonatomic, readonly, strong) VLCTime * length;
> 
> /**
>  * Returns a VLCTime object describing the length of the media resource,
> @@ -208,17 +208,17 @@ typedef NSInteger VLCMediaState;
> /**
>  * Determines if the media has already been preparsed.
>  */
> - at property (readonly) BOOL isParsed;
> + at property (nonatomic, readonly) BOOL isParsed;
> 
> /**
>  * The URL for the receiver's media resource.
>  */
> - at property (readonly) NSURL * url;
> + at property (nonatomic, readonly, strong) NSURL * url;
> 
> /**
>  * The receiver's sub list.
>  */
> - at property (readonly) VLCMediaList * subitems;
> + at property (nonatomic, readonly, strong) VLCMediaList * subitems;
> 
> /**
>  * get meta property for key
> @@ -245,12 +245,12 @@ typedef NSInteger VLCMediaState;
> /**
>  * The receiver's meta data as a NSDictionary object.
>  */
> - at property (readonly) NSDictionary * metaDictionary;
> + at property (nonatomic, readonly, strong) NSDictionary * metaDictionary;

Please follow Caro's advise and add the copy attribute.

Rest of the patch LGTM.

Thanks!

Felix