[vlc-devel] [PATCH 1/9] VLCKit: migrate VLCMedia to ARC

[Florent Pillet]

On 12 Jul 2014, at 11:46, Felix Paul Kühne <fkuehne at videolan.org> wrote:

> Hey Florent,
> 
>> - at property (readonly) NSDictionary * metaDictionary;
>> + at property (nonatomic, readonly, strong) NSDictionary * metaDictionary;
> 
> Please follow Caro's advise and add the copy attribute.
> 
> Rest of the patch LGTM.

Ok, sure. Then do you think the iOS version of the -(NSDictionary *)metaDictionary getter should return a copy too? Because in iOS case you are always returning the original mutable dictionary, regardless of the property declared attributes.

Florent.