[vlc-devel] [PATCH] src: input/stream: fix buffer underflow by avoiding inconsistent state in error case

David Fuhrmann david.fuhrmann at gmail.com
Tue Jun 10 21:02:46 CEST 2014

Am 10.06.2014 um 20:49 schrieb Rémi Denis-Courmont <remi at remlab.net>:

> Le mardi 10 juin 2014, 19:55:59 David Fuhrmann a écrit :
>> This leads to immediate playback problems (or stop of playback). So indeed,
>> it looks like my assumption is correct that it is possible to have a 
>> temporarily invalid i_offset value, and AStreamRefillStream will refill the
>> stream so that i_offset gets valid again.
> Then there should be no need to quirk it. So either way, the patch does not 
> seem very consistent.

Previously, the underflow was probably not „visible“ because of the MIN calls.

Anyway, if you or someone else has more insight of the topic, or better ideas how to fix it, I’m very interested to read them. For now, the patch at least solves the issue I’m experiencing.

With best regards,

More information about the vlc-devel mailing list