[vlc-devel] [PATCH] src: input/stream: fix buffer underflow by avoiding inconsistent state in error case

Rémi Denis-Courmont remi at remlab.net
Tue Jun 10 21:10:50 CEST 2014


Le mardi 10 juin 2014, 21:02:46 David Fuhrmann a écrit :
> Anyway, if you or someone else has more insight of the topic, or better
> ideas how to fix it, I’m very interested to read them. For now, the patch
> at least solves the issue I’m experiencing.

The patch appears ostensibly wrong. Why would the offset point to the end of 
the track buffer when refill fails? That does not seem to make sense. And even 
then, why in only one of the cases where refill fails and not the others?

-- 
Rémi Denis-Courmont
http://www.remlab.net/




More information about the vlc-devel mailing list