[vlc-devel] [PATCH] lib: fix typos in libvlc_media_player_set_equalizer

Adrien Maglo magsoft at videolan.org
Tue Jun 17 11:14:25 CEST 2014


Le 16/06/2014 20:06, Rémi Denis-Courmont a écrit :
> Le 2014-06-16 22:47, Adrien Maglo a écrit :
>> @@ -1517,7 +1517,7 @@ int libvlc_media_player_set_equalizer(
>> libvlc_media_player_t *p_mi, libvlc_equal
>>              var_SetString( p_aout, "equalizer-bands", bands );
>>          }
>>
>> -        var_SetString( p_mi, "audio-filter", p_equalizer ?
>> "equalizer" : "" );
>> +        var_SetString( p_aout, "audio-filter", p_equalizer ?
>> "equalizer" : "" );
>
> Are you sure that works across changes of audio output plugin? I
> strongly doubt it.

This seems to work. I think that playlist_EnableAudioFilter() uses the 
same method.
However, there is an issue with the default "flat" "equalizer-preset" 
that overwrite the "equalizer-bands" variable.

Best regards,


-- 
MagSoft




More information about the vlc-devel mailing list