[vlc-devel] [PATCH] lib: fix typos in libvlc_media_player_set_equalizer

Rémi Denis-Courmont remi at remlab.net
Tue Jun 17 11:26:28 CEST 2014


Le 2014-06-17 17:14, Adrien Maglo a écrit :
> Le 16/06/2014 20:06, Rémi Denis-Courmont a écrit :
>> Le 2014-06-16 22:47, Adrien Maglo a écrit :
>>> @@ -1517,7 +1517,7 @@ int libvlc_media_player_set_equalizer(
>>> libvlc_media_player_t *p_mi, libvlc_equal
>>>              var_SetString( p_aout, "equalizer-bands", bands );
>>>          }
>>>
>>> -        var_SetString( p_mi, "audio-filter", p_equalizer ?
>>> "equalizer" : "" );
>>> +        var_SetString( p_aout, "audio-filter", p_equalizer ?
>>> "equalizer" : "" );
>>
>> Are you sure that works across changes of audio output plugin? I
>> strongly doubt it.
>
> This seems to work. I think that playlist_EnableAudioFilter() uses
> the same method.

I don't think the playlist can ever change its (primary) audio output 
plugin, so the comparison should be meaningless.

-- 
Rémi Denis-Courmont



More information about the vlc-devel mailing list