[vlc-devel] [PATCH 08/10] Removes xspf generation in access/directory.c in favor of new pf_readdir callback

Rémi Denis-Courmont remi at remlab.net
Thu Jun 19 14:59:36 CEST 2014

Le 2014-06-19 19:56, Rémi Denis-Courmont a écrit :
> Le 2014-06-19 17:29, Julien 'Lta' BALLET a écrit :
>> (...) maybe could we think about using a
>> small hack to handle this, like storing the device/inode couple as 
>> an
>> info_t on the input item ?
>> This way ill be able to walk up the tree in
>> playlist/directory.c to prevent such infinite recursion.
> I don't think that playlist demuxers should have access to their
> ancestors, and I fear that would create "interesting" new race
> conditions. If it comes to that, I would prefer passing data from the
> parent to the children instead, e.g. via input item options.

We can also check the ancestor directories iteratively from FileOpen(). 
This requires more I/O system calls, but the data should be cached by 
the OS anyway.

Rémi Denis-Courmont

More information about the vlc-devel mailing list