[vlc-devel] [PATCH 08/10] Removes xspf generation in access/directory.c in favor of new pf_readdir callback

Julien 'Lta' BALLET elthariel at gmail.com
Thu Jun 19 15:14:05 CEST 2014

On Thu, Jun 19, 2014 at 2:59 PM, Rémi Denis-Courmont <remi at remlab.net>
> AFAIK, CIFS has inodes where available.

I've checked this yesterday on the wire, answer is no (at least for
SMB1/CIFS). There isn't any id-like field in the relevant messages

> Your patch series effectively enforces the "collapse" mode and removes
the other two.
> Then the playlist code will merrily expand all nodes recursively at it
iterates them. You
> need to solve this before your patch series is merged.

The other 2 modes will be back as soon as we find a solution for the issues
you raised to our awareness (and expand will be the default again). I
wasn't wanting to implement it until i had some feeling that it wouldn't be
useless :)

 > Another option is to require the pf_readdir accesses to generate opaque
GUIDs for their items.

I'm fond of that solution. Should the GUIDs be returned by the callback
directly or can i store them in an info_t ? or in a new input_item_t field ?

We can also check the ancestor directories iteratively from FileOpen().
> This requires more I/O system calls, but the data should be cached by the
> OS anyway.

If you don't mind, i'd rather go for the previous one, since this provide
us with some generic solution to the problem.

Btw, Thanks for your pointers on this issue.

Julien 'Lta' BALLET.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140619/e02169fd/attachment.html>

More information about the vlc-devel mailing list