[vlc-devel] [PATCH 08/10] Removes xspf generation in access/directory.c in favor of new pf_readdir callback

Rémi Denis-Courmont remi at remlab.net
Thu Jun 19 15:54:55 CEST 2014

Le 2014-06-19 21:14, Julien 'Lta' BALLET a écrit :
>  > Another option is to require the pf_readdir accesses to generate
> opaque GUIDs for their items.
> Im fond of that solution. Should the GUIDs be returned by the 
> callback
> directly or can i store them in an info_t ? or in a new input_item_t
> field ?

The unique ID would have to be computed by the access, so it needs to 
come from pf_readdir(). But that's easier said than done. It's also left 
completely undefined where (or how) the identifiers would be checked.

>> We can also check the ancestor directories iteratively from
>> FileOpen(). This requires more I/O system calls, but the data should
>> be cached by the OS anyway.
> If you dont mind, id rather go for the previous one, since this
> provide us with some generic solution to the problem.

It is more generic but it is also way under-specified.

Rémi Denis-Courmont

More information about the vlc-devel mailing list