[vlc-devel] [vlc-commits] configure: unbreak cross-pkg-config support with contrib

[Rafaël Carré]

On 03/03/14 15:07, Rémi Denis-Courmont wrote:
> On Mon, 03 Mar 2014 14:22:08 +0100, Rafaël Carré <funman at videolan.org>
> wrote:
>> On 03/01/14 20:44, Rémi Denis-Courmont wrote:
>>> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Mar 
>>> 1 16:00:32 2014 +0200| [d280b44e2def2bca73745f857f4c8b165c1ccc05] |
>>> committer: Rémi Denis-Courmont
>>>
>>> configure: unbreak cross-pkg-config support with contrib
>>
>> What is 'cross-pkg-config tools' exactly ?
> 
> $(CROSS)-pkg-config.

As far as I know this is a debian/fedora/whatever custom script, not
part of pkg-config.

>> I only saw something like this in Fedora and I have no idea yet how
>> hacky it is.
> 
> Debian does it too and I believe it is part of pkg-config.

So, no.

>> This breaks automated android and windows builds.
> 
> This *fixes* Windows build. More correctly, this does what it says it
> does. Well, as far as building anyway. Packaging is of course still
> seriously broken for other reasons.

If you have a problem with Windows, ask, and I will gladly help you.

>> Revert asap.
> 
> Absolutely not permitted. I am not reintroducing a hack that is clearly
> interfering with proper functioning.

I am not asking your permission, buildbot and my builds were working
perfectly before your not-discussed change.

As you were informed already I am maintaining Windows builds so this
patch is going away until further notice.