[vlc-devel] [PATCH 1/2] Added hotkeys to increase/decrease subtitle fontsize

[Jean-Baptiste Kempf]

On 04 Mar, Subodh Shrestha wrote :
> Ctrl+a increases subtitle fontsize
> Ctrl+Shift+a decreases subtitle fontsize

Please don't use Ctrl. Use Alt.

> -
> + 

Empty not-wanted change.

> +        case ACTIONID_FONTSIZE_UP:
> +            if ( p_filter )
> +            {
> +                int rel_fontsize = var_InheritInteger( p_filter, "freetype-rel-fontsize");
> +                msg_Err(p_filter, "Old Relative Fontsize:%i", rel_fontsize);
> +                var_Create( p_filter, "freetype-rel-fontsize", VLC_VAR_INTEGER);
> +                var_SetInteger( p_filter, "freetype-rel-fontsize", --rel_fontsize);

I really doubt this a correct way.
Create?

> +    //SS>>
> +    filter_t *p_filter = (filter_t *)libvlc;
> +    //SS<<

What is that?

> -
> +    

See above.

> +        //SS
> +        msg_Err(p_filter, "here");

...


This patch needs a lot of cleaning, I'm sorry...

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device