[vlc-devel] [PATCH 1/2] Added hotkeys to increase/decrease subtitle fontsize

[Subodh Shrestha]

Please see patch 2 ( uploaded with patch 1) for the cleanup. I will upload
a new clean patch as per Felix's suggestion.


On Tuesday, March 4, 2014, Jean-Baptiste Kempf <jb at videolan.org> wrote:

> On 04 Mar, Subodh Shrestha wrote :
> > Ctrl+a increases subtitle fontsize
> > Ctrl+Shift+a decreases subtitle fontsize
>
> Please don't use Ctrl. Use Alt.
>
> > -
> > +
>
> Empty not-wanted change.
>
> > +        case ACTIONID_FONTSIZE_UP:
> > +            if ( p_filter )
> > +            {
> > +                int rel_fontsize = var_InheritInteger( p_filter,
> "freetype-rel-fontsize");
> > +                msg_Err(p_filter, "Old Relative Fontsize:%i",
> rel_fontsize);
> > +                var_Create( p_filter, "freetype-rel-fontsize",
> VLC_VAR_INTEGER);
> > +                var_SetInteger( p_filter, "freetype-rel-fontsize",
> --rel_fontsize);
>
> I really doubt this a correct way.
> Create?
>

I don't understand your comment here. If I don't use var_create, I can't
seem to update the freetype-rel-fontsize config variable. I will look to
see if there's a better way.


>
> > +    //SS>>
> > +    filter_t *p_filter = (filter_t *)libvlc;
> > +    //SS<<
>
> What is that?
>

It's the module to associate with the freetype-rel-fontsize config variable
when I retrieve it above.


>
> > -
> > +
>
> See above.
>
> > +        //SS
> > +        msg_Err(p_filter, "here");
>
> ...
>
>
> This patch needs a lot of cleaning, I'm sorry...


> With my kindest regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140304/3eeaa5aa/attachment.html>