[vlc-devel] [PATCH] Add basic iOS Dialog provider

[Jean-Baptiste Kempf]

On 05 Mar, Felix Paul Kühne wrote :
> +dnl
> +AC_ARG_ENABLE(ios-dialog-provider,
> +  [  --enable-ios-dialog-provider iOS dialog module (default disabled)])
> +if test "x${enable_ios_dialog_provider}" != "xno" &&
> +  (test "${SYS}" = "darwin" || test "${enable_ios_dialog_provider}" = "yes")
> +then
> +  VLC_ADD_LIBS([ios_dialog_provider],[-Wl,-framework,UIKit])
> +  VLC_ADD_PLUGIN([ios_dialog_provider])
> +fi
> +AM_CONDITIONAL(ENABLE_IOS_DIALOG_PROVIDER, [test "$enable_ios_dialog_provider" != "no"])

Do you need that?
Can't you ENABLE_IOS_DIALOG_PROVIDER if iOS?

> @@ -0,0 +1,5 @@
> +AM_LIBTOOLFLAGS=--tag=CC

Do you need this?

> +- (id)initWithTitle:(NSString *)title message:(NSString *)message cancelButtonTitle:(NSString *)cancelButtonTitle otherButtonTitles:(NSArray *)otherButtonTitles;
> +    VLCBlockingAlertView *alert = [[VLCBlockingAlertView alloc] initWithTitle:[dialog objectForKey:@"title"] message:[dialog objectForKey:@"message"] delegate:nil cancelButtonTitle:@"OK" otherButtonTitles:nil];
> +        alert = [[VLCBlockingAlertView alloc] initWithTitle:[dialog objectForKey:@"title"] message:[dialog objectForKey:@"message"] delegate:nil cancelButtonTitle:[dialog objectForKey:@"cancel"] otherButtonTitles:[dialog objectForKey:@"yes"], [dialog objectForKey:@"no"], nil];

Are you competing for the longest VLC line of code?  :D

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device