[vlc-devel] [PATCH] Add basic iOS Dialog provider

[Felix Paul Kühne]

Hey J-B,

On 05.03.2014, at 20:54, Jean-Baptiste Kempf <jb at videolan.org> wrote:

> On 05 Mar, Felix Paul Kühne wrote :
>> +dnl
>> +AC_ARG_ENABLE(ios-dialog-provider,
>> +  [  --enable-ios-dialog-provider iOS dialog module (default disabled)])
>> +if test "x${enable_ios_dialog_provider}" != "xno" &&
>> +  (test "${SYS}" = "darwin" || test "${enable_ios_dialog_provider}" = "yes")
>> +then
>> +  VLC_ADD_LIBS([ios_dialog_provider],[-Wl,-framework,UIKit])
>> +  VLC_ADD_PLUGIN([ios_dialog_provider])
>> +fi
>> +AM_CONDITIONAL(ENABLE_IOS_DIALOG_PROVIDER, [test "$enable_ios_dialog_provider" != "no"])
> 
> Do you need that?
> Can't you ENABLE_IOS_DIALOG_PROVIDER if iOS?

In theory, sure. However, there is no "if iOS" yet. It would be dearly needed to automagically flip a few modules within the build system like Rémi asked for when we merged the CoreAnimation-layer-vout.

>> @@ -0,0 +1,5 @@
>> +AM_LIBTOOLFLAGS=--tag=CC
> 
> Do you need this?

This is copy & paste. Let me try without.

> 
>> +- (id)initWithTitle:(NSString *)title message:(NSString *)message cancelButtonTitle:(NSString *)cancelButtonTitle otherButtonTitles:(NSArray *)otherButtonTitles;
>> +    VLCBlockingAlertView *alert = [[VLCBlockingAlertView alloc] initWithTitle:[dialog objectForKey:@"title"] message:[dialog objectForKey:@"message"] delegate:nil cancelButtonTitle:@"OK" otherButtonTitles:nil];
>> +        alert = [[VLCBlockingAlertView alloc] initWithTitle:[dialog objectForKey:@"title"] message:[dialog objectForKey:@"message"] delegate:nil cancelButtonTitle:[dialog objectForKey:@"cancel"] otherButtonTitles:[dialog objectForKey:@"yes"], [dialog objectForKey:@"no"], nil];
> 
> Are you competing for the longest VLC line of code?  :D

lol.

Right, I could shorten it by using the modern Obj-C syntax which is well understood by all clang versions supported by VLC's iOS port.

Cheers,

Felix