[vlc-devel] [PATCH 04/11] Display: Support rotated movies.

Matthias Keiser matthias at tristan-inc.com
Thu Mar 6 22:26:31 CET 2014


Am 06.03.2014 um 21:35 schrieb Rémi Denis-Courmont <remi at remlab.net>:

> Is this (and all other) for the sake of the principle, because I think it is a 
> no-op. Now that the logic was moved to chain, are you sure you need all this 
> snippet?

I left it in because I thought it fixes a memory leak, but I should have cleaned it up a bit, sorry (and make a separate patch).
But I'm confused, why do you say es_format_Clean is a no-op? It frees stuff that es_format_InitFromVideo might malloc, mainly the "video palette" (of which I'll gladly admit that I have no idea what it is).




More information about the vlc-devel mailing list