[vlc-devel] [PATCH 04/11] Display: Support rotated movies.

Rémi Denis-Courmont remi at remlab.net
Wed Mar 12 19:33:36 CET 2014


Le jeudi 6 mars 2014, 22:26:31 Matthias Keiser a écrit :
> Am 06.03.2014 um 21:35 schrieb Rémi Denis-Courmont <remi at remlab.net>:
> > Is this (and all other) for the sake of the principle, because I think it
> > is a no-op. Now that the logic was moved to chain, are you sure you need
> > all this snippet?
> 
> I left it in because I thought it fixes a memory leak, but I should have
> cleaned it up a bit, sorry (and make a separate patch).

If there is a leak, the fix should be a separate patch.

> But I'm confused, why do you say es_format_Clean is a no-op?

I thought we would not be manipulating any of the few non-immediate 
es_format_t members there. But there is palette, so maybe there was a bug.

-- 
Rémi Denis-Courmont
http://www.remlab.net/




More information about the vlc-devel mailing list