[vlc-devel] [PATCH 01/11] MP4 demux: only set fragmented flag if filecontains movie fragment atoms.

[Matthias Keiser]

Am 07.03.2014 um 06:25 schrieb Ilkka Ollakka <ileoo at videolan.org>:

> On Thu, Mar 06, 2014 at 10:45:33PM +0100, Matthias Keiser wrote:
> 
> Hi,
> 
>> Am 06.03.2014 um 21:30 schrieb Jean-Baptiste Kempf <jb at videolan.org>:
>>> On 06 Mar, Matthias Keiser wrote :
>>>> +    //FIXME: relying on STREAM_CAN_FASTSEEK to decide if we can parse
>>>> +    // a file is a bad heuristic, because local files are always
>>>> +    // fast-seekable.
> 
>>> I still don't get your point.
>>> If it is local, we can always parse it, no?
> 
>> My confusion described here still isn't cleared up: https://mailman.videolan.org/pipermail/vlc-devel/2014-February/096812.html
>> But if you tell me it is ok, I'll of course remove the comment.
> 
> Actually that STREAM_CAN_FASTSEEK is there so vlc fallbacks to avformat
> mp4 demuxer in case of http access, where our mp4 demuxer at the moment
> did really lousy job for seeking all around and being slow in that
> sense. So initially it was meant to opt-out flag for demuxing for slow
> access where seek isn't that nice option (commit
> 45f7ca3d6cff34b10f2cf314c15fca9066e8ccf8).
> 

Ok, but now the plugin is discarded if it *is* fast seekable. Which, if I'm not mistaken, local files alway are. However, we only reach that code path if we don't have a smooth box, and I'm suspecting we might always have one with local files (I didn't investigate, sorry).

> -- 
> Ilkka Ollakka
> Your talents will be recognized and suitably rewarded.
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel