[vlc-devel] [PATCH 01/11] MP4 demux: only set fragmented flag if filecontains movie fragment atoms.

Ilkka Ollakka ileoo at videolan.org
Fri Mar 7 13:05:33 CET 2014

On Fri, Mar 07, 2014 at 08:56:56AM +0100, Matthias Keiser wrote:


> Ok, but now the plugin is discarded if it *is* fast seekable. Which,
> if I'm not mistaken, local files alway are. However, we only reach
> that code path if we don't have a smooth box, and I'm suspecting we
> might always have one with local files (I didn't investigate, sorry).

Yes, it seems that there is bug in those conditionals there. Initial
idea for that fastseek was that we wouldn't use our own mp4 demuxer over
http etc, seems that it got mixed up at some point. Feel free to fix
that if you happen to have patch in hand. Nice find anyway.

Ilkka Ollakka
The number of computer scientists in a room is inversely proportional
to the number of bugs in their code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140307/e59b1eed/attachment.sig>

More information about the vlc-devel mailing list