[vlc-devel] [PATCH 5/5] Make xcb_x11 vout module handle rotated movies.

[Matthias Keiser]

Am 14.03.2014 um 09:31 schrieb Rémi Denis-Courmont <remi at remlab.net>:

> On Fri, 14 Mar 2014 01:00:11 +0100, Matthias Keiser
> <matthias at tristan-inc.com> wrote:
>> ---
>> modules/video_output/xcb/x11.c | 3 +++
>> 1 file changed, 3 insertions(+)
>> 
>> diff --git a/modules/video_output/xcb/x11.c
>> b/modules/video_output/xcb/x11.c
>> index 7bdb944..afdc1fc 100644
>> --- a/modules/video_output/xcb/x11.c
>> +++ b/modules/video_output/xcb/x11.c
>> @@ -112,6 +112,9 @@ static int Open (vlc_object_t *obj)
>>     vd->sys = sys;
>>     sys->pool = NULL;
>> 
>> +    video_format_t fmt_rot = vd->fmt;
>> +    video_format_ApplyRotation(&fmt_rot, &vd->fmt);
>> +
> 
> I think this patch is a no-op... It should not be needed.

Actually I think this is integral for the transform filter to kick in, right? As you mentioned earlier, the order of the arguments for video_format_ApplyRotation is a bit counterintuitive, maybe that's what's throwing you off?
If it's ok, I'd rather fix the current bugs of the remaining patches and get them merged, and then do another round of cosmetics (in-place video_format_ApplyRotation, optimizations in OpenGL.c etc…).


>>     /* Get window, connect to X server */
>>     xcb_connection_t *conn;
>>     const xcb_screen_t *scr;
> 
> -- 
> Rémi Denis-Courmont
> Sent from my collocated server
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel