[vlc-devel] [PATCH 5/5] Make xcb_x11 vout module handle rotated movies.

[Rémi Denis-Courmont]

On Fri, 14 Mar 2014 11:42:43 +0100, Matthias Keiser
<matthias at tristan-inc.com> wrote:
> Am 14.03.2014 um 09:31 schrieb Rémi Denis-Courmont <remi at remlab.net>:
> 
>> On Fri, 14 Mar 2014 01:00:11 +0100, Matthias Keiser
>> <matthias at tristan-inc.com> wrote:
>>> ---
>>> modules/video_output/xcb/x11.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>> 
>>> diff --git a/modules/video_output/xcb/x11.c
>>> b/modules/video_output/xcb/x11.c
>>> index 7bdb944..afdc1fc 100644
>>> --- a/modules/video_output/xcb/x11.c
>>> +++ b/modules/video_output/xcb/x11.c
>>> @@ -112,6 +112,9 @@ static int Open (vlc_object_t *obj)
>>>     vd->sys = sys;
>>>     sys->pool = NULL;
>>> 
>>> +    video_format_t fmt_rot = vd->fmt;

This line assigns a value that is never used, since fmt_rot gets
overwritten by the next line.

>>> +    video_format_ApplyRotation(&fmt_rot, &vd->fmt);

And this line computes a value into fmt_rot that is never used.

>>> +
>> 
>> I think this patch is a no-op... It should not be needed.
> 
> Actually I think this is integral for the transform filter to kick in,
> right?

No. The patch inserts a no-op. The added code has no side effects.

-- 
Rémi Denis-Courmont
Sent from my collocated server