[vlc-devel] [PATCH] Revert "libvlc: equalizer: ISO frequencies are the new default"

Ronald Wright logiconcepts819 at gmail.com
Sat Mar 15 20:41:25 CET 2014

Back in August 2013, I proposed making the equalizer module use the ISO bands
by default rather than the VLC bands, but it remains to be seen whether ISO
frequencies are to become the new default.

Commit 03c813954a392c7dae1a0ff24d3fd2292d1c45a5 changed the API to return
values corresponding to the ISO frequencies.  However, this commit was
dependent on a patch that involved changing the default equalizer bands to ISO
in the equalizer module, which was never applied because Jean-Baptiste Kempf
remained hesitant about the idea.  Therefore, the actual bands still being used
by libvlc are the default VLC bands.  By keeping this particular piece of code
in libvlc, at least in the Android VLC application, the displayed frequencies
are inconsistent with what is actually being used by the equalizer module.
This inconsistency will appear in other applications that use libvlc if the
application relies on the API to display the band frequencies.

Since VLC 2.2.0 is in a feature freeze and contains the inconsistency, commit
03c813954a392c7dae1a0ff24d3fd2292d1c45a5 should just be reverted.
 lib/audio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/audio.c b/lib/audio.c
index 51d3ff3..a79de6e 100644
--- a/lib/audio.c
+++ b/lib/audio.c
@@ -474,7 +474,7 @@ float libvlc_audio_equalizer_get_band_frequency( unsigned u_index )
     if ( u_index >= EQZ_BANDS_MAX )
         return -1.f;
-    return f_iso_frequency_table_10b[ u_index ];
+    return f_vlc_frequency_table_10b[ u_index ];

More information about the vlc-devel mailing list