[vlc-devel] [PATCH] Revert "libvlc: equalizer: ISO frequencies are the new default"
edward.c.wang at compdigitec.com
Sat Mar 15 22:03:33 CET 2014
On 2014-03-15 15:41, Ronald Wright <logiconcepts819 at gmail.com> wrote:
> Back in August 2013, I proposed making the equalizer module use the ISO bands
> by default rather than the VLC bands, but it remains to be seen whether ISO
> frequencies are to become the new default.
> Commit 03c813954a392c7dae1a0ff24d3fd2292d1c45a5 changed the API to return
> values corresponding to the ISO frequencies. However, this commit was
> dependent on a patch that involved changing the default equalizer bands to ISO
> in the equalizer module, which was never applied because Jean-Baptiste Kempf
> remained hesitant about the idea. Therefore, the actual bands still being used
> by libvlc are the default VLC bands. By keeping this particular piece of code
> in libvlc, at least in the Android VLC application, the displayed frequencies
> are inconsistent with what is actually being used by the equalizer module.
> This inconsistency will appear in other applications that use libvlc if the
> application relies on the API to display the band frequencies.
> Since VLC 2.2.0 is in a feature freeze and contains the inconsistency, commit
> 03c813954a392c7dae1a0ff24d3fd2292d1c45a5 should just be reverted.
Or alternatively just add a switch/flag that permits the API users to
choose whatever bands they please...
More information about the vlc-devel