[vlc-devel] [PATCH] Revert "libvlc: equalizer: ISO frequencies are the new default"

[Ron Wright]

On Sat, Mar 15, 2014 at 4:03 PM, Edward Wang
<edward.c.wang at compdigitec.com> wrote:
> On 2014-03-15 15:41, Ronald Wright <logiconcepts819 at gmail.com> wrote:
>>
>> Back in August 2013, I proposed making the equalizer module use the ISO
>> bands
>> by default rather than the VLC bands, but it remains to be seen whether
>> ISO
>> frequencies are to become the new default.
>>
>> Commit 03c813954a392c7dae1a0ff24d3fd2292d1c45a5 changed the API to return
>> values corresponding to the ISO frequencies.  However, this commit was
>> dependent on a patch that involved changing the default equalizer bands to
>> ISO
>> in the equalizer module, which was never applied because Jean-Baptiste
>> Kempf
>> remained hesitant about the idea.  Therefore, the actual bands still being
>> used
>> by libvlc are the default VLC bands.  By keeping this particular piece of
>> code
>> in libvlc, at least in the Android VLC application, the displayed
>> frequencies
>> are inconsistent with what is actually being used by the equalizer module.
>> This inconsistency will appear in other applications that use libvlc if
>> the
>> application relies on the API to display the band frequencies.
>>
>> Since VLC 2.2.0 is in a feature freeze and contains the inconsistency,
>> commit
>> 03c813954a392c7dae1a0ff24d3fd2292d1c45a5 should just be reverted.
>
>
> Or alternatively just add a switch/flag that permits the API users to choose
> whatever bands they please...
>
> Regards,
>         Edward Wang
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

I already offered a proposal similar to this one, but these were their replies:

On Thu, Aug 15, 2013 at 10:24 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le jeudi 15 août 2013 11:21:25 Edward Wang a écrit :
>> On 2013-08-15 11:18, Jean-Baptiste Kempf <jb at videolan.org> wrote:
>> > On 15 Aug, Ron Wright wrote :
>> >> >I thought that the VLC bands (60-170-310-600-1k-3k-6k-12k-14k-16k)
>> >> >were the only option before I brought up the idea of the ISO bands
>> >> >(31-63-125-250-500-1k-2k-4k-8k-16k).  Now I am confused because it
>> >> >seems to me that you want me to change the default in the equalizer
>> >> >module itself as well or else eliminate the VLC bands altogether.
>> >
>> > Well, the "VLC" bands are just a copy of Winamp bands IIRC, and an
>> > artefact of the past.
>> >
>> > Maybe I'm missing something but I don't see why we need VLC bands in new
>> > code. 12k-14k-16k bands seems a bit too much in those frequencies...
>> >
>> > Keeping them in VLC, why not. But in libVLC?
>>
>> The Winamp bands are still popularly used no? So I doubt there is that
>> much harm in keeping both around.
>
> I don't care which one, but I don't want two. It's confusing.
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

On Thu, Aug 15, 2013 at 10:26 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On 15 Aug, Edward Wang wrote :
>> The Winamp bands are still popularly used no? So I doubt there is
>> that much harm in keeping both around.
>
> API clutter, AFAIC
> Best regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

It is my understanding from these replies that both Jean-Baptiste
Kempf and Rémi Denis-Courmont disapproved the idea of supporting more
than one set of bands in the LibVLC API.

Regards,

Ron Wright