[vlc-devel] Glitching at start of MPEG2 streams

[Ilkka Ollakka]

On Mon, Mar 17, 2014 at 01:23:23PM +0000, Alex Woods wrote:
> Hello,

Hi,


> I've now isolated the cause of this issue to a few lines of code within
> VLC's modules/codec/avcodec/video.c:618-627

Nice bug hunting there

>         if( b_null_size && !p_sys->b_flush &&
>             p_context->width > 0 && p_context->height > 0 )
>         {
>             /* Reparse it to not drop the I frame */
>             b_null_size = false;
>             if( p_sys->b_hurry_up )
>                 p_context->skip_frame = p_sys->i_skip_frame;
>             i_used = avcodec_decode_video2( p_context, p_sys->p_ff_pic,
>                                            &b_gotpicture, &pkt );
>         }
> Could this section of code be a work-around for an issue in libav that
> no longer exists?

I didn't yet have time to check actual code, but yes, there has quite a
lot of code to work-around old libavcodec issues in past that nobody
just didn't check again and remove.

-- 
Ilkka Ollakka
Not intended to diagnose, treat, cure or prevent any disease.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140317/d87e1fac/attachment.sig>