[vlc-devel] [PATCH 2/3] tools: add GNU sed
gseanmcg at gmail.com
Sat Mar 22 21:27:08 CET 2014
On Wed, Mar 12, 2014 at 4:52 AM, Rafaël Carré <funman at videolan.org> wrote:
> On 03/12/14 04:00, Sean McGovern wrote:
> > On Tue, Mar 11, 2014 at 3:20 PM, Rafaël Carré <funman at videolan.org>
> >> Hello,
> >> We had several occurences of using POSIX sed, e.g. for OSX.
> >> Where do we need GNU sed?
> >> I don't know if this patch is really needed or not but if we use it
> >> we might want to revisit our sed usage (and use -i without suffix
> >> generously)
> >> On 03/11/14 20:12, Sean McGovern wrote:
> >>> ---
> >>> extras/tools/bootstrap | 12 ++++++++++++
> >>> extras/tools/packages.mak | 3 +++
> >>> extras/tools/tools.mak | 17 +++++++++++++++++
> >>> 3 files changed, 32 insertions(+)
> > As I mentioned on IRC, extras/ and contrib/ are both chock full of sed -i
> > (in-place editing) usage -- it's not POSIX, as witnessed here:
> > http://pubs.opengroup.org/onlinepubs/009695399/utilities/sed.html
> Hm right, we use -i.orig which might be BSD functionality but not POSIX.
> Patch is OK.
-- Sean McG.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel