[vlc-devel] [PATCH 10/10] video_filter/swscale.c: The mapping for VLC_CODEC_ARGB into PIX_FMT_BGR32_1 is wrong.

[Rémi Denis-Courmont]

ARGB is used by X. This is needed for the work-in-progress X RENDER support. I think the current mapping is correct though I have not checked in a few months.

-- 
Rémi Denis-Courmont
Sent from my NVIDIA Tegra-powered device

----- Reply message -----
De : "Luca Barbato" <lu_zero at gentoo.org>
Pour : <vlc-devel at videolan.org>
Objet : [vlc-devel] [PATCH 10/10] video_filter/swscale.c: The mapping for VLC_CODEC_ARGB into PIX_FMT_BGR32_1 is wrong.
Date : lun., mai 12, 2014 18:55

On 12/05/14 12:04, jpsaman at videolan.org wrote:
> From: Jean-Paul Saman <jpsaman at videolan.org>
> 
> Mapping VLC_CODEC_ARGB to PIX_FMT_BGR32_1 maps plane R -> B and B -> R. This makes the colors totally wrong. I believe the correct PIX_FMT mapping should be PIX_FMT_RGB32. Then R -> R, G -> G and B -> B.
> 
> Conflicts:
>  modules/video_chroma/swscale.c
> ---
>  modules/video_chroma/swscale.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/video_chroma/swscale.c b/modules/video_chroma/swscale.c
> index 6559078..ea3318e 100644
> --- a/modules/video_chroma/swscale.c
> +++ b/modules/video_chroma/swscale.c
> @@ -271,7 +271,7 @@ static void FixParameters( int *pi_fmt, bool *pb_has_a, bool *pb_swap_uv, vlc_fo
>          *pb_has_a = true;
>          break;
>      case VLC_CODEC_ARGB:
> -        *pi_fmt = PIX_FMT_BGR32_1;
> +        *pi_fmt = PIX_FMT_RGB32;
>          *pb_has_a = true;
>          break;
>      case VLC_CODEC_YV12:

Seems ok to me, but who is using ARGB as it is ABGR ?

lu
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140512/dce1e6bc/attachment.html>