[vlc-devel] [PATCH] demux: avcodec: audio: reset reference time on backward seek (fix #9176)

[Rémi Denis-Courmont]

No. That value males no sense there, period. The _whole_ point of a symbolic constant is that we can change it. And this one has changed.

Giving it a second meaning is wrong and not acceptable.

-- 
Rémi Denis-Courmont
Sent from my NVIDIA Tegra-powered device

----- Reply message -----
De : "Francois Cartegnie" <fcvlcdev at free.fr>
Pour : "Mailing list for VLC media player developers" <vlc-devel at videolan.org>
Objet : [vlc-devel] [PATCH] demux: avcodec: audio: reset reference time on backward seek (fix #9176)
Date : ven., mai 16, 2014 02:25

Le 01/05/2014 12:26, Rémi Denis-Courmont a écrit :
> 
>> +            date_Get(
>> &p_sys->end_date ) - p_block->i_pts > AOUT_MAX_PREPARE_TIME
>> +      ) )

> No please. MAX_PREPARE_TIME is only for use by audio outputs (to size play-out 
> buffers) and the core (to detect overflow). This really does not belong in 
> decoders.
> 

I have no real way to guess if there's a discontinuity, as some blocks
might not have duration.

Matching the AOUT_MAX_PREPARE_TIME limit is better than picking an
arbitrary value.

Francois

_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20140516/e0d70983/attachment.html>