[vlc-devel] [PATCH] DPI-awareness - new patchset

[Jean-Baptiste Kempf]

On 09 Nov, Jarrad Whitaker wrote :
> 1: the previously posted patch to the list

I still have an issue with the hardcodec 96.0 number hardcoded
everywhere, and not as a define.

> 2 (attachment): more changes, incl. loading of high-res icons when
> they are available and dynamic drawing of the volume bar (so this may
> change rendering at 96dpi slightly).

Why change the default rendering?

> In my mucking around I also
> changed the volume icon behaviour slightly (low/med/high/over for <=33
> / <=66 / <=100 / <inf respectively), and changed the native volume
> slider to use the same maximum as the default one (currently it looks
> like the slider is hardcoded to max out at 200 whereas the default
> uses your platform's max if available).

No, this has nothing to do with the rest of the DPI patch.
This should be splitted and in a different patchset.

> 3: SVG icons for most of the toolbar (all of the default buttons in
> the standard and adv. toolbars), and a tiny script (requires inkscape
> in your $PATH) to use these to generate 128px PNGs

OK.

> 4: the 128px PNGs as generated by aforementioned script, I'm not sure
> whether you will want these in the repo or not, as it's probably
> better to build them when needed but this would require Inkscape as a
> build-dep.

No, we need to commit the PNGs and the SVGs.
Or just use QtSvg to display them, which is probably a better solution.

> Currently I have VLC using the 128px png icons as SVG support is not
> compiled in your build routine and I lack the skillz to get it in
> there,

You just need to recompile the contrib and copy the QtSvg module.

> however I would propose the SVG icons get included even if only
> for ideological reasons (they are a "source" file for the "compiled"
> pngs). It would also make it easier for People Who Aren't Me to make
> edits to the icons later on.

SVG are better to display directly with 125%DPI and the like.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device