[vlc-devel] [PATCH] DPI-awareness - new patchset

[Jean-Baptiste Kempf]

Hello,

On 10 Nov, Jarrad Whitaker wrote :
> I can add it back in if you like, but to me it looks nearly identical, and it seems a bit silly to have two methods coded in for the same result when a single one works perfectly well in both cases.

When you explained it, it did not feel "nearly identical".
If it's hard to see the difference, then ok.

> I have already aligned all paths and stroke widths such that you get a very clean render at 32×32px. 24px is also acceptable, though with a choice of 'perfection' necessarily being a xor function, I have optimized for 32. Is this an acceptable choice?

Yes.

> > You just need to recompile the contrib and copy the QtSvg module.
> 
> I think I got QtSvg compiled correctly for static linking (was a bit tricky as we are not adding it to Qt-whole, but just Qtbase), but I could not get the qt4 gui to link against it properly (after adding the Q_IMPORT_PLUGIN macro, -L and -I flags, I was still getting linker errors). All instructions I could find are for qmake and cmake based compilation, and even getting basic qt apps to compile with autotools is hard to find much information on, let alone with a statically linked cross compilation setup. I still cannot find an autotools equivalent for the QT += svg qmake stanza, for instance.

No, you should just add -lQt5Svg to the link stage: probably by adding
to PKG_CHECK_MODULES([QT], [Qt5Core >= 5.1.0 Qt5Widgets Qt5Gui]
like this:

PKG_CHECK_MODULES([QT], [Qt5Core >= 5.1.0 Qt5Widgets Qt5Gui Qt5Svg]

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device