[vlc-devel] [PATCH] DPI-awareness - new patchset

Jarrad Whitaker jarrad.whitaker at gmail.com
Sun Nov 9 14:35:51 CET 2014


Thanks for the pointers Jean-Baptise and Francois. :) I'll clean these up tomorrow.

I can happily do almost everything you suggest, and only comment on

> Why change the default rendering?

I can add it back in if you like, but to me it looks nearly identical, and it seems a bit silly to have two methods coded in for the same result when a single one works perfectly well in both cases.

> SVG must be:
> * Cleaned
> * Compressed (and we don't want git to track metadata changes each
> time a different editor is used).
> * Aligned to a grid for lowest resolution rendering without blurring.
> (see current ones)

I have already aligned all paths and stroke widths such that you get a very clean render at 32×32px. 24px is also acceptable, though with a choice of 'perfection' necessarily being a xor function, I have optimized for 32. Is this an acceptable choice?

By cleaning, is there an automated process you are referring to? Or to supply standard SVG instead of Inkscape-extended? Or manual XML cleanup? (ewww...)

What do you mean by the metadata being excluded? Is there any way I can enforce this on future editors, or do I misunderstand you?

> That's not the way to include them in Qt. Qt has to pick the
> alternative matching the density. We don't want to change reference to
> bitmaps in code each time we introduce a higher density.
> See @2x naming.

Is this is in response to linking Qt to the 128px PNGs? There should be no further change necessary unless we end up with ~700PPI displays at any time soon; Qt happily scales down the 128px image and the result is aesthetically fine.

I agree that SVGs would be better, but -

> You just need to recompile the contrib and copy the QtSvg module.

I think I got QtSvg compiled correctly for static linking (was a bit tricky as we are not adding it to Qt-whole, but just Qtbase), but I could not get the qt4 gui to link against it properly (after adding the Q_IMPORT_PLUGIN macro, -L and -I flags, I was still getting linker errors). All instructions I could find are for qmake and cmake based compilation, and even getting basic qt apps to compile with autotools is hard to find much information on, let alone with a statically linked cross compilation setup. I still cannot find an autotools equivalent for the QT += svg qmake stanza, for instance.

Hence, 128px pngs which look nearly-as-good :)

Thanks again for the pointers and patience, I'll post an updated set in the next day or so.

Jarrad

On 09/11/14 23:21, Francois Cartegnie wrote:
> Le 09/11/2014 09:15, Jarrad Whitaker a écrit :
> > / <=66 / <=100 / <inf respectively), and changed the native volume
> > slider to use the same maximum as the default one (currently it
> > looks like the slider is hardcoded to max out at 200 whereas the
> > default uses your platform's max if available).
>
> If you start changing volume values you'll get in trouble here.
>
> I don't see where the rounded corners are drawn in the non bitmap version.
>
> > 3: SVG icons for most of the toolbar (all of the default buttons
> > in the standard and adv. toolbars), and a tiny script (requires
> > inkscape in your $PATH) to use these to generate 128px PNGs
>
> No way to require inkscape. At least there's rsvg, but we don't want
> to add another requirement (pre build or QtSVG at runtime) just for
> icons that needs to be rendered once. Bitmaps must exist. svg
> mandatory as source. Another reasons: see PNG comments.
>
> SVG must be:
> * Cleaned
> * Compressed (and we don't want git to track metadata changes each
> time a different editor is used).
> * Aligned to a grid for lowest resolution rendering without blurring.
> (see current ones)
>
>
> That's not the way to include them in Qt. Qt has to pick the
> alternative matching the density. We don't want to change reference to
> bitmaps in code each time we introduce a higher density.
> See @2x naming.
>
> > Currently I have VLC using the 128px png icons as SVG support is
> > not compiled in your build routine and I lack the skillz to get it
> > in there, however I would propose the SVG icons get included even
> > if only for ideological reasons (they are a "source" file for the
> > "compiled" pngs). It would also make it easier for People Who
> > Aren't Me to make edits to the icons later on.
>
> PNG:
> * must be pngcrush'ed
> * should be indexed colors (saves even more).
>
>
> Francois
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>




More information about the vlc-devel mailing list